xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Improve test_bot_responds_to_empty_message().

Browse source 
This fixes the TODO of inlining get_response(), and it
makes a slightly tighter assertion about the response.
This commit is contained in:
Steve Howell 2017-12-10 06:12:06 -08:00
parent 81b207795f
commit 01f8366bea
1 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
zulip_bots/zulip_bots/test_lib.py
View file

@ -155,22 +155,17 @@ class StubBotTestCase(TestCase):
self.assertNotEqual(bot.usage(), '') self.assertNotEqual(bot.usage(), '')
def test_bot_responds_to_empty_message(self) -> None: def test_bot_responds_to_empty_message(self) -> None:
# TODO get_response should be usable here once it's merged?
bot = get_bot_message_handler(self.bot_name)
bot_handler = StubBotHandler()
if hasattr(bot, 'initialize'):
bot.initialize(bot_handler)
message = dict( message = dict(
sender_email='foo@example.com', sender_email='foo@example.com',
display_recipient='foo', display_recipient='foo',
content='', content='',
) )
bot_handler.reset_transcript()
bot.handle_message(message, bot_handler) # get_response will fail if we don't respond at all
empty_response = bot_handler.unique_response() response = self.get_response(message)
self.assertIsNotNone(empty_response)
# we also want a non-blank response
self.assertTrue(len(response['content']) >= 1)
def mock_http_conversation(self, test_name): def mock_http_conversation(self, test_name):
# type: (str) -> Any # type: (str) -> Any