From 1e5e931421518955ef1f08dbf7551d329cd23c47 Mon Sep 17 00:00:00 2001
From: "neiljp (Neil Pilgrim)" <github@kepier.clara.net>
Date: Wed, 29 Nov 2017 16:48:11 -0800
Subject: [PATCH] Tests: Extend test-lib script to support coverage parameter &
 add to test-main

---
 tools/test-lib  | 32 ++++++++++++++++++++++++--------
 tools/test-main |  1 +
 2 files changed, 25 insertions(+), 8 deletions(-)

diff --git a/tools/test-lib b/tools/test-lib
index 8b6bceb..a933fd4 100755
--- a/tools/test-lib
+++ b/tools/test-lib
@@ -1,20 +1,35 @@
 #!/usr/bin/env python
 
-import coverage
 import os
 import sys
 import unittest
+import argparse
 
 from importlib import import_module
 
+def parse_args():
+    parser = argparse.ArgumentParser()
+    parser.add_argument('--coverage',
+                        nargs='?',
+                        const=True,
+                        default=False,
+                        help='compute test coverage ("--coverage combine" to combine with previous reports)')
+    return parser.parse_args()
+
 def run_all():
     TOOLS_DIR = os.path.dirname(os.path.abspath(__file__))
     ROOT_DIR = os.path.abspath(os.path.join(TOOLS_DIR, '..'))
     BOTS_DIR = os.path.join(ROOT_DIR, 'zulib_bots')
     sys.path.insert(0, BOTS_DIR)
 
-    cov = coverage.Coverage(config_file="tools/.coveragerc")
-    cov.start()
+    options = parse_args()
+
+    if options.coverage:
+        import coverage
+        cov = coverage.Coverage(config_file="tools/.coveragerc")
+        if options.coverage == 'combine':
+            cov.load()
+        cov.start()
 
     module = import_module('zulip_bots.lib_tests')
     suite = unittest.defaultTestLoader.loadTestsFromModule(module)
@@ -25,11 +40,12 @@ def run_all():
     if result.failures or result.errors:
         sys.exit(1)
 
-    cov.stop()
-    cov.data_suffix = False  # Disable suffix so that filename is .coverage
-    cov.save()
-    cov.html_report()
-    print("HTML report saved under directory 'htmlcov'.")
+    if not result.failures and options.coverage:
+        cov.stop()
+        cov.data_suffix = False  # Disable suffix so that filename is .coverage
+        cov.save()
+        cov.html_report()
+        print("HTML report saved under directory 'htmlcov'.")
 
 if __name__ == '__main__':
     run_all()
diff --git a/tools/test-main b/tools/test-main
index 8bc13a1..a718785 100755
--- a/tools/test-main
+++ b/tools/test-main
@@ -5,3 +5,4 @@ set -ev
 tools/test-bots --coverage
 tools/test-botserver --coverage combine
 tools/test-zulip --coverage combine
+tools/test-lib --coverage combine