xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

bots: Improve error handling of yoda bot when the service is unavailable.

Browse source 
Frequent 503 errors throw index error exceptions which is misleading
to debug.
This commit is contained in:
Abhijeet Kaur 2017-08-01 01:00:42 +05:30 committed by Tim Abbott
parent a58fae5cab
commit 1e84e2eb5e
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
zulip_bots/zulip_bots/bots/yoda/yoda.py
View file

@ -27,6 +27,9 @@ HELP_MESSAGE = '''
class ApiKeyError(Exception): class ApiKeyError(Exception):
'''raise this when there is an error with the Mashape Api Key''' '''raise this when there is an error with the Mashape Api Key'''
class ServiceUnavailableError(Exception):
'''raise this when the service is unavailable.'''
class YodaSpeakHandler(object): class YodaSpeakHandler(object):
''' '''
@ -67,6 +70,8 @@ class YodaSpeakHandler(object):
return response.text return response.text
if response.status_code == 403: if response.status_code == 403:
raise ApiKeyError raise ApiKeyError
if response.status_code == 503:
raise ServiceUnavailableError
else: else:
error_message = response.text['message'] error_message = response.text['message']
logging.error(error_message) logging.error(error_message)