xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

mypy: Amend code & typing of integrations, to pass with strict-optional.

Browse source
This commit is contained in:
neiljp (Neil Pilgrim) 2017-12-22 09:51:14 -08:00 • committed by showell
parent 08bfe9d8c7
commit 33ccc04a32
6 changed files with 15 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
zulip/integrations/git/zulip_git_config.py
View file

@ -20,7 +20,7 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
from typing import Dict, Text
from typing import Dict, Text, Optional
# Change these values to configure authentication for the plugin
ZULIP_USER = "git-bot@example.com"
@ -42,7 +42,7 @@ ZULIP_API_KEY = "0123456789abcdef0123456789abcdef"
# * topic "master"
# And similarly for branch "test-post-receive" (for use when testing).
def commit_notice_destination(repo, branch, commit):
# type: (Text, Text, Text) -> Dict[Text, Text]
# type: (Text, Text, Text) -> Optional[Dict[Text, Text]]
if branch in ["master", "test-post-receive"]:
return dict(stream = "commits",
subject = u"%s" % (branch,))