xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

bots: Raise KeyError inside storage.get().

Browse source 
Our bots rely on get() raising `KeyError` if
a key does not exist.

This was a regression in this commit:

d7d2f6bbd6
This commit is contained in:
Steve Howell 2018-12-09 17:31:06 +00:00 committed by showell
parent f191d44992
commit 3d68e394dc
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
zulip_bots/zulip_bots/bots/incident/incident.py
View file

@ -2,7 +2,7 @@ import html
import json import json
import random import random
import re import re
from zulip_bots.lib import Any, StateHandlerError from zulip_bots.lib import Any
from typing import Optional, Any, Dict, Tuple from typing import Optional, Any, Dict, Tuple
@ -79,7 +79,7 @@ def parse_answer(query: str) -> Tuple[str, str]:
def generate_ticket_id(storage: Any) -> str: def generate_ticket_id(storage: Any) -> str:
try: try:
incident_num = storage.get('ticket_id') incident_num = storage.get('ticket_id')
except (StateHandlerError, KeyError): except (KeyError):
incident_num = 0 incident_num = 0
incident_num += 1 incident_num += 1
incident_num = incident_num % (1000) incident_num = incident_num % (1000)

2
zulip_bots/zulip_bots/lib.py
View file

@ -72,7 +72,7 @@ class StateHandler(object):
response = self._client.get_storage({'keys': [key]}) response = self._client.get_storage({'keys': [key]})
if response['result'] != 'success': if response['result'] != 'success':
raise StateHandlerError("Error fetching state: {}".format(str(response))) raise KeyError('key not found: ' + key)
marshalled_value = response['storage'][key] marshalled_value = response['storage'][key]
self.state_[key] = marshalled_value self.state_[key] = marshalled_value