xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

tests: Fix tests failing on Windows.

Browse source 
Tests were failing on Windows since paths are case-insensitive on it.
This uses pathlib library to compare paths on all platforms.

Fixes #651
This commit is contained in:
Ganesh Pawar 2021-03-02 14:22:12 +05:30 • committed by Tim Abbott
parent 5f1590f12a
commit 44b6fd395a
8 changed files with 23 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

7
zulip_botserver/tests/test_server.py
View file

@ -8,6 +8,7 @@ import json
from collections import OrderedDict
from importlib import import_module
from types import ModuleType
from pathlib import Path
from zulip_botserver import server
from zulip_botserver.input_parameters import parse_args
@ -214,13 +215,13 @@ class BotServerTests(BotServerTestCase):
# restructure zulip_bots, this test would fail and we would also update Botserver
# at the same time.
helloworld = import_module('zulip_bots.bots.{bot}.{bot}'.format(bot='helloworld'))
root_dir = os.path.normpath(os.path.join(os.path.dirname(os.path.abspath(__file__)), '../../'))
root_dir = Path(__file__).parents[2].as_posix()
# load valid module name
module = server.load_lib_modules(['helloworld'])['helloworld']
assert module == helloworld
# load valid file path
path = os.path.join(root_dir, 'zulip_bots/zulip_bots/bots/{bot}/{bot}.py'.format(bot='helloworld'))
path = Path(root_dir, 'zulip_bots/zulip_bots/bots/{bot}/{bot}.py'.format(bot='helloworld')).as_posix()
module = server.load_lib_modules([path])[path]
assert module.__name__ == 'custom_bot_module'
assert module.__file__ == path
@ -236,7 +237,7 @@ class BotServerTests(BotServerTestCase):
with self.assertRaisesRegexp(SystemExit, # type: ignore
'Error: Bot "{}/zulip_bots/zulip_bots/bots/helloworld.py" doesn\'t exist. '
'Please make sure you have set up the botserverrc file correctly.'.format(root_dir)):
path = os.path.join(root_dir, 'zulip_bots/zulip_bots/bots/{bot}.py'.format(bot='helloworld'))
path = Path(root_dir, 'zulip_bots/zulip_bots/bots/{bot}.py'.format(bot='helloworld')).as_posix()
module = server.load_lib_modules([path])[path]
if __name__ == '__main__':