xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

bot tests: Autospec mock bot handler.

Browse source 
This makes test development less error-prone and closer
to reality.
This commit is contained in:
derAnfaenger 2017-10-17 17:48:12 +02:00
parent 4af8bcd46e
commit 45c38d0dcf
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
zulip_bots/zulip_bots/test_lib.py
View file

@ -41,7 +41,7 @@ class BotTestCase(TestCase):
def setUp(self): def setUp(self):
# type: () -> None # type: () -> None
# Mocking ExternalBotHandler # Mocking ExternalBotHandler
self.patcher = patch('zulip_bots.lib.ExternalBotHandler') self.patcher = patch('zulip_bots.lib.ExternalBotHandler', autospec=True)
self.MockClass = self.patcher.start() self.MockClass = self.patcher.start()
self.message_handler = self.get_bot_message_handler() self.message_handler = self.get_bot_message_handler()
@ -51,7 +51,7 @@ class BotTestCase(TestCase):
def initialize_bot(self): def initialize_bot(self):
# type: () -> None # type: () -> None
self.message_handler.initialize(self.MockClass()) self.message_handler.initialize(self.MockClass(None, None))
def check_expected_responses(self, expectations, expected_method='send_reply', def check_expected_responses(self, expectations, expected_method='send_reply',
email="foo_sender@zulip.com", recipient="foo", subject="foo", email="foo_sender@zulip.com", recipient="foo", subject="foo",
@ -104,7 +104,7 @@ class BotTestCase(TestCase):
if state_handler is None: if state_handler is None:
state_handler = StateHandler() state_handler = StateHandler()
# Send message to the concerned bot # Send message to the concerned bot
self.message_handler.handle_message(message, self.MockClass(), state_handler) self.message_handler.handle_message(message, self.MockClass(None, None), state_handler)
# Check if the bot is sending a message via `send_message` function. # Check if the bot is sending a message via `send_message` function.
# Where response is a dictionary here. # Where response is a dictionary here.