xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

trello: Simplify message & response handling.

Browse source
This commit is contained in:
neiljp (Neil Pilgrim) 2018-05-27 21:46:46 -07:00 committed by showell
parent 8e1d4f524b
commit 4f224b5dbc
1 changed files with 22 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
zulip_bots/zulip_bots/bots/trello/trello.py
View file

@ -43,23 +43,23 @@ class TrelloHandler(object):
''' '''
def handle_message(self, message: Dict[str, Any], bot_handler: Any) -> None: def handle_message(self, message: Dict[str, Any], bot_handler: Any) -> None:
content = message['content'].strip() content = message['content'].strip().split()
if content == '': if content == []:
bot_handler.send_reply(message, 'Empty Query') bot_handler.send_reply(message, 'Empty Query')
return return
elif content.lower() == 'help':
content[0] = content[0].lower()
if content == ['help']:
bot_handler.send_reply(message, self.usage()) bot_handler.send_reply(message, self.usage())
return return
if content.lower() == 'list-commands': if content == ['list-commands']:
bot_reply = self.get_all_supported_commands() bot_reply = self.get_all_supported_commands()
elif content.lower() == 'get-all-boards': elif content == ['get-all-boards']:
bot_reply = self.get_all_boards() bot_reply = self.get_all_boards()
else: else:
content = content.split()
content[0] = content[0].lower()
if content[0] == 'get-all-cards': if content[0] == 'get-all-cards':
bot_reply = self.get_all_cards(content) bot_reply = self.get_all_cards(content)
elif content[0] == 'get-all-checklists': elif content[0] == 'get-all-checklists':
@ -92,16 +92,15 @@ class TrelloHandler(object):
return bot_response return bot_response
def get_board_descs(self, boards: List[str]) -> str: def get_board_descs(self, boards: List[str]) -> str:
bot_response = '' bot_response = [] # type: List[str]
get_board_desc_url = 'https://api.trello.com/1/boards/{}/' get_board_desc_url = 'https://api.trello.com/1/boards/{}/'
for index, board in enumerate(boards): for index, board in enumerate(boards):
board_desc_response = requests.get(get_board_desc_url.format(board), params=self.auth_params) board_desc_response = requests.get(get_board_desc_url.format(board), params=self.auth_params)
board_data = board_desc_response.json() board_data = board_desc_response.json()
bot_response += '{}.[{}]({}) (`{}`)\n'.format(index + 1, board_data['name'], board_data['url'], bot_response += ['{_count}.[{name}]({url}) (`{id}`)'.format(_count=index + 1, **board_data)]
board_data['id'])
return bot_response return '\n'.join(bot_response + [''])
def get_all_cards(self, content: List[str]) -> str: def get_all_cards(self, content: List[str]) -> str:
if len(content) != 2: if len(content) != 2:
@ -113,14 +112,14 @@ class TrelloHandler(object):
try: try:
cards = cards_response.json() cards = cards_response.json()
bot_response = '**Cards:** \n' bot_response = ['**Cards:** ']
for index, card in enumerate(cards): for index, card in enumerate(cards):
bot_response += '{}. [{}]({}) (`{}`)\n'.format(index + 1, card['name'], card['url'], card['id']) bot_response += ['{_count}. [{name}]({url}) (`{id}`)'.format(_count=index + 1, **card)]
except (KeyError, ValueError, TypeError): except (KeyError, ValueError, TypeError):
return RESPONSE_ERROR_MESSAGE return RESPONSE_ERROR_MESSAGE
return bot_response return '\n'.join(bot_response + [''])
def get_all_checklists(self, content: List[str]) -> str: def get_all_checklists(self, content: List[str]) -> str:
if len(content) != 2: if len(content) != 2:
@ -132,18 +131,18 @@ class TrelloHandler(object):
try: try:
checklists = checklists_response.json() checklists = checklists_response.json()
bot_response = '**Checklists:** \n' bot_response = ['**Checklists:** ']
for index, checklist in enumerate(checklists): for index, checklist in enumerate(checklists):
bot_response += '{}. `{}`:\n'.format(index + 1, checklist['name']) bot_response += ['{}. `{}`:'.format(index + 1, checklist['name'])]
if 'checkItems' in checklist: if 'checkItems' in checklist:
for item in checklist['checkItems']: for item in checklist['checkItems']:
bot_response += ' * [{}] {}\n'.format('X' if item['state'] == 'complete' else '-', item['name']) bot_response += [' * [{}] {}'.format('X' if item['state'] == 'complete' else '-', item['name'])]
except (KeyError, ValueError, TypeError): except (KeyError, ValueError, TypeError):
return RESPONSE_ERROR_MESSAGE return RESPONSE_ERROR_MESSAGE
return bot_response return '\n'.join(bot_response + [''])
def get_all_lists(self, content: List[str]) -> str: def get_all_lists(self, content: List[str]) -> str:
if len(content) != 2: if len(content) != 2:
@ -155,18 +154,18 @@ class TrelloHandler(object):
try: try:
lists = lists_response.json() lists = lists_response.json()
bot_response = '**Lists:** \n' bot_response = ['**Lists:** ']
for index, _list in enumerate(lists): for index, _list in enumerate(lists):
bot_response += '{}. {}\n'.format(index + 1, _list['name']) bot_response += ['{}. {}'.format(index + 1, _list['name'])]
if 'cards' in _list: if 'cards' in _list:
for card in _list['cards']: for card in _list['cards']:
bot_response += ' * {}\n'.format(card['name']) bot_response += [' * {}'.format(card['name'])]
except (KeyError, ValueError, TypeError): except (KeyError, ValueError, TypeError):
return RESPONSE_ERROR_MESSAGE return RESPONSE_ERROR_MESSAGE
return bot_response return '\n'.join(bot_response + [''])
handler_class = TrelloHandler handler_class = TrelloHandler