xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Make bot provisioning script install dependencies globally.

Browse source 
Previously, a bot's dependencies were installed within the
bot's directoy, which is unconventional and doesn't work with tests.
This commit is contained in:
Robert Hönig 2018-01-05 22:27:22 +01:00
parent e48a958780
commit 56a9cbe5af
1 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
zulip_bots/zulip_bots/provision.py
View file

@ -13,16 +13,12 @@ from typing import Iterator
def provision_bot(path_to_bot, force): def provision_bot(path_to_bot, force):
# type: (str, bool) -> None # type: (str, bool) -> None
req_path = os.path.join(path_to_bot, 'requirements.txt') req_path = os.path.join(path_to_bot, 'requirements.txt')
install_path = os.path.join(path_to_bot, 'bot_dependencies')
if os.path.isfile(req_path): if os.path.isfile(req_path):
bot_name = os.path.basename(path_to_bot) bot_name = os.path.basename(path_to_bot)
logging.info('Installing dependencies for {}...'.format(bot_name)) logging.info('Installing dependencies for {}...'.format(bot_name))
if not os.path.isdir(install_path):
os.makedirs(install_path)
# pip install -r $BASEDIR/requirements.txt -t $BASEDIR/bot_dependencies --quiet # pip install -r $BASEDIR/requirements.txt -t $BASEDIR/bot_dependencies --quiet
rcode = pip.main(['install', '-r', req_path, '-t', install_path, '--quiet']) rcode = pip.main(['install', '-r', req_path, '--quiet'])
if rcode != 0: if rcode != 0:
logging.error('Error. Check output of `pip install` above for details.') logging.error('Error. Check output of `pip install` above for details.')
@ -32,8 +28,6 @@ def provision_bot(path_to_bot, force):
else: else:
logging.info('Installed dependencies successfully.') logging.info('Installed dependencies successfully.')
sys.path.insert(0, install_path)
def parse_args(available_bots): def parse_args(available_bots):
# type: (Iterator[str]) -> argparse.Namespace # type: (Iterator[str]) -> argparse.Namespace