xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

refactor: Extract display_config_file_errors().

Browse source 
This will be useful for handling errors with third party
config files.
This commit is contained in:
Steve Howell 2017-11-27 14:47:59 -08:00 committed by showell
parent 8a15452525
commit 57c90ddca0
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
zulip_bots/zulip_bots/lib.py
View file

@ -200,6 +200,12 @@ def is_private_message_from_another_user(message_dict, current_user_id):
return current_user_id != message_dict['sender_id'] return current_user_id != message_dict['sender_id']
return False return False
def display_config_file_errors(error_msg, config_file):
# type: (str, str) -> None
file_contents = open(config_file).read()
print('\nERROR: {} seems to be broken:\n\n{}'.format(config_file, file_contents))
print('\nMore details here:\n\n{}\n'.format(error_msg))
def run_message_handler_for_bot(lib_module, quiet, config_file, bot_name): def run_message_handler_for_bot(lib_module, quiet, config_file, bot_name):
# type: (Any, bool, str, str) -> Any # type: (Any, bool, str, str) -> Any
# #
@ -221,9 +227,7 @@ def run_message_handler_for_bot(lib_module, quiet, config_file, bot_name):
try: try:
client = Client(config_file=config_file, client=client_name) client = Client(config_file=config_file, client=client_name)
except configparser.Error as e: except configparser.Error as e:
file_contents = open(config_file).read() display_config_file_errors(str(e), config_file)
print('\nERROR: {} seems to be broken:\n\n{}'.format(config_file, file_contents))
print('\nMore details here:\n\n' + str(e) + '\n')
sys.exit(1) sys.exit(1)
bot_dir = os.path.dirname(lib_module.__file__) bot_dir = os.path.dirname(lib_module.__file__)