xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

testing: Properly exclude files for linting in Windows.

Browse source 
For files to be excluded in Windows, their paths have to
be normalized, so that the string matching works.
This commit is contained in:
derAnfaenger 2017-07-23 13:18:53 +02:00 committed by Tim Abbott
parent 428ded449e
commit 5dd359fd4d
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/custom_check.py
View file

@ -161,7 +161,7 @@ def build_custom_checkers(by_lang):
# This rule might give false positives in virtualenv setup files which should be excluded, # This rule might give false positives in virtualenv setup files which should be excluded,
# and comments which should be rewritten to avoid use of "python2", "python3", etc. # and comments which should be rewritten to avoid use of "python2", "python3", etc.
{'pattern': 'python[23]', {'pattern': 'python[23]',
'exclude': set(['tools/provision',]), 'exclude': set(['tools/provision']),
'description': 'Explicit python invocations should not include a version'}, 'description': 'Explicit python invocations should not include a version'},
{'pattern': '(^|\s)open\s*\(', {'pattern': '(^|\s)open\s*\(',
'description': 'open() should not be used in Zulip\'s bots. Use functions' 'description': 'open() should not be used in Zulip\'s bots. Use functions'

2
tools/server_lib/lister.py
View file

@ -66,7 +66,7 @@ def list_files(targets=[], ftypes=[], use_shebang=True, modified_only=False,
# sys.argv as str, so that battle is already lost. Settle for hoping # sys.argv as str, so that battle is already lost. Settle for hoping
# everything is UTF-8. # everything is UTF-8.
repository_root = subprocess.check_output(['git', 'rev-parse', '--show-toplevel']).strip().decode('utf-8') repository_root = subprocess.check_output(['git', 'rev-parse', '--show-toplevel']).strip().decode('utf-8')
exclude_abspaths = [os.path.join(repository_root, fpath).rstrip('/') for fpath in exclude] exclude_abspaths = [os.path.normpath(os.path.join(repository_root, fpath)) for fpath in exclude]
cmdline = ['git', 'ls-files'] + targets cmdline = ['git', 'ls-files'] + targets
if modified_only: if modified_only: