xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

zulip: Amend default value of remove_subscriptions:principals to None.

Browse source 
Having a default parameter as '[]' may not be an issue with the current
implementation, but general practice is to default to None and assign
a default list subsequently.
This commit is contained in:
neiljp (Neil Pilgrim) 2018-03-31 11:32:45 -07:00 committed by Tim Abbott
parent 7e360c244c
commit 83b41a2e9e
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
zulip/zulip/__init__.py
View file

@ -816,11 +816,14 @@ class Client(object):
request=request, request=request,
) )
def remove_subscriptions(self, streams, principals=[]): def remove_subscriptions(self, streams, principals=None):
# type: (Iterable[str], Optional[Iterable[str]]) -> Dict[str, Any] # type: (Iterable[str], Optional[Iterable[str]]) -> Dict[str, Any]
''' '''
See examples/unsubscribe for example usage. See examples/unsubscribe for example usage.
''' '''
if principals is None:
principals = []
request = dict( request = dict(
subscriptions=streams, subscriptions=streams,
principals=principals principals=principals