xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

zulip_bots: Fix get_storage request arguments in StateHandler.

Browse source
This commit is contained in:
Shubham Dhama 2018-06-28 10:48:34 +05:30 committed by showell
parent 88b649d689
commit 918e63a220
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
zulip/zulip/__init__.py
View file

@ -1006,7 +1006,7 @@ class Client(object):
>>> client.update_storage({'storage': {"entry 1": "value 1", "entry 2": "value 2", "entry 3": "value 3"}}) >>> client.update_storage({'storage': {"entry 1": "value 1", "entry 2": "value 2", "entry 3": "value 3"}})
>>> client.get_storage() >>> client.get_storage()
{'result': 'success', 'storage': {"entry 1": "value 1", "entry 2": "value 2", "entry 3": "value 3"}, 'msg': ''} {'result': 'success', 'storage': {"entry 1": "value 1", "entry 2": "value 2", "entry 3": "value 3"}, 'msg': ''}
>>> client.get_storage(keys=('entry 1', 'entry 3')) >>> client.get_storage({'keys': ["entry 1", "entry 3"]})
{'result': 'success', 'storage': {'entry 1': 'value 1', 'entry 3': 'value 3'}, 'msg': ''} {'result': 'success', 'storage': {'entry 1': 'value 1', 'entry 3': 'value 3'}, 'msg': ''}
''' '''
return self.call_endpoint( return self.call_endpoint(

2
zulip_bots/zulip_bots/lib.py
View file

@ -69,7 +69,7 @@ class StateHandler(object):
if key in self.state_: if key in self.state_:
return self.demarshal(self.state_[key]) return self.demarshal(self.state_[key])
response = self._client.get_storage(keys=(key,)) response = self._client.get_storage({'keys': [key]})
if response['result'] != 'success': if response['result'] != 'success':
raise StateHandlerError("Error fetching state: {}".format(str(response))) raise StateHandlerError("Error fetching state: {}".format(str(response)))

4
zulip_bots/zulip_bots/tests/test_lib.py
View file

@ -27,7 +27,7 @@ class FakeClient:
result='success', result='success',
) )
def get_storage(self, keys): def get_storage(self, request):
return dict( return dict(
result='success', result='success',
storage=self.storage, storage=self.storage,
@ -97,7 +97,7 @@ class LibTest(TestCase):
result='success', result='success',
storage=dict(non_cached_key='[5]'))) storage=dict(non_cached_key='[5]')))
val = state_handler.get('non_cached_key') val = state_handler.get('non_cached_key')
client.get_storage.assert_called_with(keys=('non_cached_key',)) client.get_storage.assert_called_with({'keys': ['non_cached_key']})
self.assertEqual(val, [5]) self.assertEqual(val, [5])
# value must already be cached # value must already be cached