xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

hg integration: Use explicit sys.exit.

Browse source
This commit is contained in:
neiljp (Neil Pilgrim) 2018-01-07 09:08:26 -08:00 committed by showell
parent 55df1886cc
commit 9502e0eb9a
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
zulip/integrations/hg/zulip-changegroup.py
View file

@ -28,6 +28,7 @@
from __future__ import absolute_import from __future__ import absolute_import
import zulip import zulip
import sys
from six.moves import range from six.moves import range
from typing import Any, Optional, Text from typing import Any, Optional, Text
from mercurial import ui, repo from mercurial import ui, repo
@ -112,7 +113,7 @@ def get_config(ui, item):
return ui.configlist('zulip', item)[0] return ui.configlist('zulip', item)[0]
except IndexError: except IndexError:
ui.warn("Zulip: Could not find required item {} in hg config.".format(item)) ui.warn("Zulip: Could not find required item {} in hg config.".format(item))
exit(1) sys.exit(1)
def hook(ui, repo, **kwargs): def hook(ui, repo, **kwargs):
# type: (ui, repo, **Text) -> None # type: (ui, repo, **Text) -> None
@ -126,7 +127,7 @@ def hook(ui, repo, **kwargs):
if hooktype != "changegroup": if hooktype != "changegroup":
ui.warn("Zulip: {hooktype} not supported\n".format(hooktype=hooktype)) ui.warn("Zulip: {hooktype} not supported\n".format(hooktype=hooktype))
exit(1) sys.exit(1)
ctx = repo.changectx(node) ctx = repo.changectx(node)
branch = ctx.branch() branch = ctx.branch()
@ -140,14 +141,14 @@ def hook(ui, repo, **kwargs):
watched_branches = [b.lower().strip() for b in branch_whitelist.split(",")] watched_branches = [b.lower().strip() for b in branch_whitelist.split(",")]
if branch.lower() not in watched_branches: if branch.lower() not in watched_branches:
ui.debug("Zulip: ignoring event for {branch}\n".format(branch=branch)) ui.debug("Zulip: ignoring event for {branch}\n".format(branch=branch))
exit(0) sys.exit(0)
if branch_blacklist: if branch_blacklist:
# Don't send notifications for branches we've ignored. # Don't send notifications for branches we've ignored.
ignored_branches = [b.lower().strip() for b in branch_blacklist.split(",")] ignored_branches = [b.lower().strip() for b in branch_blacklist.split(",")]
if branch.lower() in ignored_branches: if branch.lower() in ignored_branches:
ui.debug("Zulip: ignoring event for {branch}\n".format(branch=branch)) ui.debug("Zulip: ignoring event for {branch}\n".format(branch=branch))
exit(0) sys.exit(0)
# The first and final commits in the changeset. # The first and final commits in the changeset.
base = repo[node].rev() base = repo[node].rev()
@ -160,7 +161,7 @@ def hook(ui, repo, **kwargs):
if not (email and api_key): if not (email and api_key):
ui.warn("Zulip: missing email or api_key configurations\n") ui.warn("Zulip: missing email or api_key configurations\n")
ui.warn("in the [zulip] section of your .hg/hgrc.\n") ui.warn("in the [zulip] section of your .hg/hgrc.\n")
exit(1) sys.exit(1)
stream = get_config(ui, "stream") stream = get_config(ui, "stream")
# Give a default stream if one isn't provided. # Give a default stream if one isn't provided.