xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

bot testing: Improve checking of fixtures in mock_http_conversation.

Browse source 
This ensures required fields are present in the fixture dict/json,
improving testing & allowing file to pass mypy with strict-optional.
This commit is contained in:
neiljp (Neil Pilgrim) 2017-12-22 21:15:06 -08:00 committed by showell
parent 438f711bb7
commit 9853d85fb7
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
zulip_bots/zulip_bots/request_test_lib.py
View file

@ -43,9 +43,14 @@ def mock_http_conversation(http_data):
mock_result.assert_called_with(http_request['api_url'], **args) mock_result.assert_called_with(http_request['api_url'], **args)
http_request = http_data.get('request') try:
http_response = http_data.get('response') http_request = http_data['request']
http_headers = http_data.get('response-headers') http_response = http_data['response']
http_headers = http_data['response-headers']
except KeyError:
print("ERROR: Failed to find 'request', 'response' or 'response-headers' fields in fixture")
raise
http_method = http_request.get('method', 'GET') http_method = http_request.get('method', 'GET')
if http_method == 'GET': if http_method == 'GET':