xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

bots: Fix unit tests not running in Vagrant.

Browse source 
`test-bots` would not run in Vagrant, displaying
the error "ValueError: no such test method in <class
'bots_test_lib.BotTestCase'>: runTest" This was due to
the `BotTestCase` class inheriting from the TestCase
class, even though it was not a unit test on its own.

This commit removes the inheritance of TestCase and
specifies `test_define` as the `runTest` method in
`TestDefineBot`.
This commit is contained in:
derAnfaenger 2017-05-25 00:26:51 +02:00 committed by Tim Abbott
parent 073468ebba
commit 9b67e94ba8
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
contrib_bots/bots/define/test_define.py
View file

@ -42,7 +42,7 @@ class TestDefineBot(TestCase):
messages.append(message2) messages.append(message2)
return messages return messages
def test_define(self): def runTest(self):
# type: None -> None # type: None -> None
# Edit bot_module to test different bots, the below code can be looped for all the bots. # Edit bot_module to test different bots, the below code can be looped for all the bots.
bot_module = os.path.join(our_dir, "define.py") bot_module = os.path.join(our_dir, "define.py")

3
contrib_bots/bots_test_lib.py
View file

@ -8,14 +8,13 @@ import sys
import unittest import unittest
from mock import MagicMock, patch from mock import MagicMock, patch
from unittest import TestCase
from run import get_lib_module from run import get_lib_module
from bot_lib import StateHandler from bot_lib import StateHandler
from contrib_bots import bot_lib from contrib_bots import bot_lib
from six.moves import zip from six.moves import zip
class BotTestCase(TestCase): class BotTestCase():
def mock_test(self, messages, message_handler, bot_response): def mock_test(self, messages, message_handler, bot_response):
# type: (List[Dict[str, str]], Function) -> None # type: (List[Dict[str, str]], Function) -> None