From a744fd93162c2e5b48c90198027fc3b2fa22f647 Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Thu, 17 Aug 2017 10:41:23 -0700 Subject: [PATCH] provision: Fix shell quoting and whitespace. --- tools/provision | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/provision b/tools/provision index 9132262..8de221d 100755 --- a/tools/provision +++ b/tools/provision @@ -15,18 +15,18 @@ if [[ "$OSTYPE" == "cygwin" ]]; then VENVBINDIR="Scripts" fi -source $BASEDIR/zulip-api-py2-venv/$VENVBINDIR/activate +source "$BASEDIR/zulip-api-py2-venv/$VENVBINDIR/activate" RVAL=$? -if [ $RVAL -ne 0 ]; then +if [ "$RVAL" -ne 0 ]; then echo "Failed to activate virtualenv." exit fi # Install python dependencies if needed. -cmp $BASEDIR/zulip-api-py2-venv/installed-requirements.txt requirements.txt 2>/dev/null +cmp "$BASEDIR/zulip-api-py2-venv/installed-requirements.txt" requirements.txt 2>/dev/null RVAL=$? # Return value of the comparision. 0 means files are same. -if [ $RVAL -ne 0 ]; then - pip install -r $BASEDIR/requirements.txt - cp requirements.txt $BASEDIR/zulip-api-py2-venv/installed-requirements.txt +if [ "$RVAL" -ne 0 ]; then + pip install -r "$BASEDIR/requirements.txt" + cp requirements.txt "$BASEDIR/zulip-api-py2-venv/installed-requirements.txt" echo "Requirements installed." fi