xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

front: Add helper func to test command's error.

Browse source
This commit is contained in:
novokrest 2018-06-23 13:56:43 +03:00 committed by showell
parent 0d3189b3b0
commit aa6afbd2fe
1 changed files with 14 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
zulip_bots/zulip_bots/bots/front/test_front.py
View file

@ -1,4 +1,4 @@
from typing import Any, Dict from typing import Any, Dict, Optional
from zulip_bots.test_lib import BotTestCase, DefaultTests from zulip_bots.test_lib import BotTestCase, DefaultTests
@ -35,9 +35,7 @@ class TestFrontBot(BotTestCase, DefaultTests):
self.verify_reply('archive', "Conversation was archived.") self.verify_reply('archive', "Conversation was archived.")
def test_archive_error(self) -> None: def test_archive_error(self) -> None:
with self.mock_config_info({'api_key': "TEST"}): self._test_command_error('archive')
with self.mock_http_conversation('archive_error'):
self.verify_reply('archive', 'Something went wrong.')
def test_delete(self) -> None: def test_delete(self) -> None:
with self.mock_config_info({'api_key': "TEST"}): with self.mock_config_info({'api_key': "TEST"}):
@ -45,9 +43,7 @@ class TestFrontBot(BotTestCase, DefaultTests):
self.verify_reply('delete', "Conversation was deleted.") self.verify_reply('delete', "Conversation was deleted.")
def test_delete_error(self) -> None: def test_delete_error(self) -> None:
with self.mock_config_info({'api_key': "TEST"}): self._test_command_error('delete')
with self.mock_http_conversation('delete_error'):
self.verify_reply('delete', 'Something went wrong.')
def test_spam(self) -> None: def test_spam(self) -> None:
with self.mock_config_info({'api_key': "TEST"}): with self.mock_config_info({'api_key': "TEST"}):
@ -55,9 +51,7 @@ class TestFrontBot(BotTestCase, DefaultTests):
self.verify_reply('spam', "Conversation was marked as spam.") self.verify_reply('spam', "Conversation was marked as spam.")
def test_spam_error(self) -> None: def test_spam_error(self) -> None:
with self.mock_config_info({'api_key': "TEST"}): self._test_command_error('spam')
with self.mock_http_conversation('spam_error'):
self.verify_reply('spam', 'Something went wrong.')
def test_restore(self) -> None: def test_restore(self) -> None:
with self.mock_config_info({'api_key': "TEST"}): with self.mock_config_info({'api_key': "TEST"}):
@ -65,9 +59,7 @@ class TestFrontBot(BotTestCase, DefaultTests):
self.verify_reply('open', "Conversation was restored.") self.verify_reply('open', "Conversation was restored.")
def test_restore_error(self) -> None: def test_restore_error(self) -> None:
with self.mock_config_info({'api_key': "TEST"}): self._test_command_error('open')
with self.mock_http_conversation('open_error'):
self.verify_reply('open', 'Something went wrong.')
def test_comment(self) -> None: def test_comment(self) -> None:
body = "@bender, I thought you were supposed to be cooking for this party." body = "@bender, I thought you were supposed to be cooking for this party."
@ -77,9 +69,16 @@ class TestFrontBot(BotTestCase, DefaultTests):
def test_comment_error(self) -> None: def test_comment_error(self) -> None:
body = "@bender, I thought you were supposed to be cooking for this party." body = "@bender, I thought you were supposed to be cooking for this party."
self._test_command_error('comment', body)
def _test_command_error(self, command_name: str, command_arg: Optional[str] = None) -> None:
bot_command = command_name
if command_arg:
bot_command += ' {}'.format(command_arg)
with self.mock_config_info({'api_key': "TEST"}): with self.mock_config_info({'api_key': "TEST"}):
with self.mock_http_conversation('comment_error'): with self.mock_http_conversation('{}_error'.format(command_name)):
self.verify_reply('comment ' + body, 'Something went wrong.') self.verify_reply(bot_command, 'Something went wrong.')
class TestFrontBotWrongTopic(BotTestCase, DefaultTests): class TestFrontBotWrongTopic(BotTestCase, DefaultTests):
bot_name = 'front' bot_name = 'front'