xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

bots: Use user 'id' instead of 'name' in is_private function.

Browse source 
Names are not guaranteed to be unique, user ids should
be used when comparing if the sender and receiver are the same.
This commit is contained in:
Abhijeet Kaur 2017-08-18 16:59:55 +05:30 committed by Tim Abbott
parent 735943379f
commit ae434cd26c
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
zulip_bots/zulip_bots/lib.py
View file

@ -79,6 +79,7 @@ class ExternalBotHandler(object):
self._client = client self._client = client
self._root_dir = root_dir self._root_dir = root_dir
try: try:
self.user_id = user_profile['user_id']
self.full_name = user_profile['full_name'] self.full_name = user_profile['full_name']
self.email = user_profile['email'] self.email = user_profile['email']
except KeyError: except KeyError:
@ -176,10 +177,10 @@ def extract_query_without_mention(message, client):
def is_private(message, client): def is_private(message, client):
# type: (Dict[str, Any], ExternalBotHandler) -> bool # type: (Dict[str, Any], ExternalBotHandler) -> bool
# bot will not reply if the sender name is the same as the bot name # bot will not reply if the sender id is the same as the bot id
# to prevent infinite loop # to prevent infinite loop
if message['type'] == 'private': if message['type'] == 'private':
return client.full_name != message['sender_full_name'] return client.user_id != message['sender_id']
return False return False
def run_message_handler_for_bot(lib_module, quiet, config_file, bot_name): def run_message_handler_for_bot(lib_module, quiet, config_file, bot_name):