xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

tests: Extend mock_http_conversation to support POST requests.

Browse source
This commit is contained in:
Skunk 2017-12-02 09:59:57 -08:00 committed by showell
parent fab9d46f93
commit bd0462f7b5
1 changed files with 37 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
zulip_bots/zulip_bots/test_lib.py
View file

@ -159,6 +159,13 @@ def read_bot_fixture_data(bot_name, test_name):
http_data = json.loads(content) http_data = json.loads(content)
return http_data return http_data
def get_response(http_response, http_headers):
# type: (Dict[str, Any], Dict[str, Any]) -> Any
mock_result = requests.Response()
mock_result._content = json.dumps(http_response).encode() # type: ignore # This modifies a "hidden" attribute.
mock_result.status_code = http_headers.get('status', 200)
return mock_result
@contextmanager @contextmanager
def mock_http_conversation(http_data): def mock_http_conversation(http_data):
# type: (Dict[str, Any]) -> Any # type: (Dict[str, Any]) -> Any
@ -174,11 +181,11 @@ def mock_http_conversation(http_data):
http_request = http_data.get('request') http_request = http_data.get('request')
http_response = http_data.get('response') http_response = http_data.get('response')
http_headers = http_data.get('response-headers') http_headers = http_data.get('response-headers')
http_method = http_request.get('method', 'GET')
if http_method == 'GET':
with patch('requests.get') as mock_get: with patch('requests.get') as mock_get:
mock_result = requests.Response() mock_get.return_value = get_response(http_response, http_headers)
mock_result._content = json.dumps(http_response).encode() # type: ignore # We are modifying a "hidden" attribute.
mock_result.status_code = http_headers.get('status', 200)
mock_get.return_value = mock_result
yield yield
if 'params' in http_request: if 'params' in http_request:
params = http_request.get('params', None) params = http_request.get('params', None)
@ -188,6 +195,22 @@ def mock_http_conversation(http_data):
mock_get.assert_called_with(http_request['api_url'], headers=headers) mock_get.assert_called_with(http_request['api_url'], headers=headers)
else: else:
mock_get.assert_called_with(http_request['api_url']) mock_get.assert_called_with(http_request['api_url'])
else:
with patch('requests.post') as mock_post:
mock_post.return_value = get_response(http_response, http_headers)
yield
if 'json' in http_request:
json = http_request.get('json', None)
if 'params' in http_request:
params = http_request.get('params', None)
mock_post.assert_called_with(http_request['api_url'], json=json, params=params)
else:
mock_post.assert_called_with(http_request['api_url'], json=json)
elif 'params' in http_request:
params = http_request.get('params', None)
mock_post.assert_called_with(http_request['api_url'], params=params)
else:
mock_post.assert_called_with(http_request['api_url'])
class BotTestCase(StubBotTestCase): class BotTestCase(StubBotTestCase):
"""Test class for common Bot test helper methods""" """Test class for common Bot test helper methods"""