From bdc4901f070824a099e37280863a8e49c7eccbd3 Mon Sep 17 00:00:00 2001 From: Eeshan Garg Date: Wed, 27 Oct 2021 20:21:08 +0530 Subject: [PATCH] pypi: Include py.typed in MANIFEST.in. According to the `setuptools` docs, once `include_package_data=True` is passed to `setup()`, it will only include package data specified in `MANIFEST.in`, and will ignore the `package_data` argument passed to `setup()`. Therefore, `py.typed` was not included in our latest PyPI release 0.8.1. Since we specify all of our package data in the `MANIFEST.in` file already, it makes more sense to include mention `py.typed` there so that it is included in the expected fashion. See https://github.com/pypa/setuptools/issues/1461 for background. Fixes #732. --- zulip/MANIFEST.in | 1 + zulip/setup.py | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/zulip/MANIFEST.in b/zulip/MANIFEST.in index 34d7b67..14399df 100644 --- a/zulip/MANIFEST.in +++ b/zulip/MANIFEST.in @@ -1,3 +1,4 @@ recursive-include integrations * include README.md include zulip/examples/* +include zulip/py.typed diff --git a/zulip/setup.py b/zulip/setup.py index 5898e0d..cd0806c 100755 --- a/zulip/setup.py +++ b/zulip/setup.py @@ -63,7 +63,6 @@ package_info = dict( "zulip-api=zulip.cli:cli", ], }, - package_data={"zulip": ["py.typed"]}, ) # type: Dict[str, Any] setuptools_info = dict(