From bdf0c7ff5c872ab8226617b064a77b90e0b96026 Mon Sep 17 00:00:00 2001 From: Rohitt Vashishtha Date: Tue, 28 Apr 2020 20:59:59 +0530 Subject: [PATCH] bots: Use ids for sending message. --- zulip_bots/zulip_bots/lib.py | 2 +- zulip_bots/zulip_bots/tests/test_lib.py | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/zulip_bots/zulip_bots/lib.py b/zulip_bots/zulip_bots/lib.py index f8dc626..8e6e133 100644 --- a/zulip_bots/zulip_bots/lib.py +++ b/zulip_bots/zulip_bots/lib.py @@ -165,7 +165,7 @@ class ExternalBotHandler: if message['type'] == 'private': return self.send_message(dict( type='private', - to=[x['email'] for x in message['display_recipient']], + to=[x['id'] for x in message['display_recipient']], content=response, widget_content=widget_content, )) diff --git a/zulip_bots/zulip_bots/tests/test_lib.py b/zulip_bots/zulip_bots/tests/test_lib.py index c6116ae..5d3d766 100644 --- a/zulip_bots/zulip_bots/tests/test_lib.py +++ b/zulip_bots/zulip_bots/tests/test_lib.py @@ -19,6 +19,7 @@ class FakeClient: user_id='alice', full_name='Alice', email='alice@example.com', + id=42, ) def update_storage(self, payload): @@ -117,11 +118,11 @@ class LibTest(TestCase): bot_details=None, bot_config_file=None ) - to = {'email': 'Some@User'} + to = {'id': 43} expected = [({'type': 'private', 'display_recipient': [to]}, - {'type': 'private', 'to': [to['email']]}, None), + {'type': 'private', 'to': [to['id']]}, None), ({'type': 'private', 'display_recipient': [to, profile]}, - {'type': 'private', 'to': [to['email'], profile['email']]}, 'widget_content'), + {'type': 'private', 'to': [to['id'], profile['id']]}, 'widget_content'), ({'type': 'stream', 'display_recipient': 'Stream name', 'subject': 'Topic'}, {'type': 'stream', 'to': 'Stream name', 'subject': 'Topic'}, 'test widget')] response_text = "Response"