xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

XKCD: Adjust tests to use loops, inline responses, remove comments.

Browse source
This commit is contained in:
neiljp (Neil Pilgrim) 2017-12-08 10:58:29 -08:00 committed by showell
parent d97401df86
commit d4284f88f9
1 changed files with 8 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
zulip_bots/zulip_bots/bots/xkcd/test_xkcd.py
View file

@ -40,13 +40,10 @@ class TestXkcdBot(BotTestCase):
def test_invalid_comic_ids(self, mock_logging_exception): def test_invalid_comic_ids(self, mock_logging_exception):
invalid_id_txt = "Sorry, there is likely no xkcd comic strip with id: #" invalid_id_txt = "Sorry, there is likely no xkcd comic strip with id: #"
bot_response = invalid_id_txt + "999999999" for comic_id, fixture in (('0', 'test_not_existing_id_2'),
with self.mock_http_conversation('test_not_existing_id'): ('999999999', 'test_not_existing_id')):
self.verify_reply('999999999', bot_response) with self.mock_http_conversation(fixture):
self.verify_reply(comic_id, invalid_id_txt + comic_id)
bot_response = invalid_id_txt + "0"
with self.mock_http_conversation('test_not_existing_id_2'):
self.verify_reply('0', bot_response)
def test_help_responses(self): def test_help_responses(self):
help_txt = "xkcd bot supports these commands:" help_txt = "xkcd bot supports these commands:"
@ -56,14 +53,7 @@ class TestXkcdBot(BotTestCase):
* `@xkcd latest` to fetch the latest comic strip from xkcd. * `@xkcd latest` to fetch the latest comic strip from xkcd.
* `@xkcd random` to fetch a random comic strip from xkcd. * `@xkcd random` to fetch a random comic strip from xkcd.
* `@xkcd <comic id>` to fetch a comic strip based on `<comic id>` e.g `@xkcd 1234`.''' * `@xkcd <comic id>` to fetch a comic strip based on `<comic id>` e.g `@xkcd 1234`.'''
# Empty query, no request made to the Internet. self.verify_reply('', err_txt.format('') + commands)
bot_response = err_txt.format('')+commands self.verify_reply('help', help_txt + commands)
self.verify_reply('', bot_response) # Example invalid command
self.verify_reply('x', err_txt.format('x') + commands)
# 'help' command.
bot_response = help_txt+commands
self.verify_reply('help', bot_response)
# wrong command.
bot_response = err_txt.format('x')+commands
self.verify_reply('x', bot_response)