xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

botserver testing: Move to six.assertRaisesRegex from Regexp variant.

Browse source 
This ensures 2/3 compatibility. The mypy test also now passes, though
the six stubs appear very minimal - maybe incorrect?
This commit is contained in:
neiljp (Neil Pilgrim) 2017-11-15 09:44:52 -08:00 committed by Tim Abbott
parent 9ed0fa9e6f
commit d929cdb91e
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
zulip_botserver/tests/test_server.py
View file

@ -4,6 +4,7 @@ import unittest
from typing import Any from typing import Any
from zulip_botserver import server from zulip_botserver import server
from .server_test_lib import BotServerTestCase from .server_test_lib import BotServerTestCase
import six
class BotServerTests(BotServerTestCase): class BotServerTests(BotServerTestCase):
class MockMessageHandler(object): class MockMessageHandler(object):
@ -48,9 +49,10 @@ class BotServerTests(BotServerTestCase):
'site': 'http://localhost', 'site': 'http://localhost',
} }
} }
# This complains about mismatching argument types, yet they are all correct? # TODO: The following passes mypy, though the six stubs don't match the
# We should investigate and file an issue in mypy. # unittest ones, so we could file a mypy bug to improve this.
self.assertRaisesRegexp(ImportError, # type: ignore six.assertRaisesRegex(self,
ImportError,
"Bot \"nonexistent-bot\" doesn't exists. Please " "Bot \"nonexistent-bot\" doesn't exists. Please "
"make sure you have set up the flaskbotrc file correctly.", "make sure you have set up the flaskbotrc file correctly.",
lambda: self.assert_bot_server_response(available_bots=available_bots, lambda: self.assert_bot_server_response(available_bots=available_bots,