xenofem/python-zulip-api
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

mypy: Support files without extensions for scripts in /tools.

Browse source 
This assumes that files passed in force_include without any extension are meant
to be run with mypy, and thus assumed to be python scripts.

Also, we ignore the most of the tools dir, except for the tools/deploy script
for which #349 adds type annotations.
This commit is contained in:
Rohitt Vashishtha 2018-03-23 07:07:49 +05:30 committed by showell
parent 2f4b276799
commit e49ecfcd39
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tools/run-mypy
View file

@ -29,7 +29,7 @@ exclude = [
"zulip_bots/zulip_bots/terminal.py", "zulip_bots/zulip_bots/terminal.py",
"zulip_bots/zulip_bots/simple_lib.py", "zulip_bots/zulip_bots/simple_lib.py",
"zulip_bots/zulip_bots/lib_tests.py", "zulip_bots/zulip_bots/lib_tests.py",
"tools/test-lib", "tools",
] ]
# These files will be included even if excluded by a rule above. # These files will be included even if excluded by a rule above.
@ -94,7 +94,8 @@ force_include = [
"zulip_bots/zulip_bots/bots/susi/susi.py", "zulip_bots/zulip_bots/bots/susi/susi.py",
"zulip_bots/zulip_bots/bots/susi/test_susi.py", "zulip_bots/zulip_bots/bots/susi/test_susi.py",
"zulip_bots/zulip_bots/bots/front/front.py", "zulip_bots/zulip_bots/bots/front/front.py",
"zulip_bots/zulip_bots/bots/front/test_front.py" "zulip_bots/zulip_bots/bots/front/test_front.py",
"tools/deploy"
] ]
parser = argparse.ArgumentParser(description="Run mypy on files tracked by git.") parser = argparse.ArgumentParser(description="Run mypy on files tracked by git.")
@ -130,14 +131,17 @@ files_dict = cast(Dict[str, List[str]],
extless_only=args.scripts_only)) extless_only=args.scripts_only))
for inpath in force_include: for inpath in force_include:
try:
ext = os.path.splitext(inpath)[1].split('.')[1] ext = os.path.splitext(inpath)[1].split('.')[1]
except IndexError:
ext = 'py' # type: str
files_dict[ext].append(inpath) files_dict[ext].append(inpath)
pyi_files = set(files_dict['pyi']) pyi_files = set(files_dict['pyi'])
python_files = [fpath for fpath in files_dict['py'] python_files = [fpath for fpath in files_dict['py']
if not fpath.endswith('.py') or fpath + 'i' not in pyi_files] if not fpath.endswith('.py') or fpath + 'i' not in pyi_files]
repo_python_files = OrderedDict([('zulip', []), ('zulip_bots', []), ('zulip_botserver', [])]) repo_python_files = OrderedDict([('zulip', []), ('zulip_bots', []), ('zulip_botserver', []), ('tools', [])])
for file_path in python_files: for file_path in python_files:
repo = PurePath(file_path).parts[0] repo = PurePath(file_path).parts[0]
if repo in repo_python_files: if repo in repo_python_files: