From f81843f18925847439c7a487c46f2ad5d4aaa790 Mon Sep 17 00:00:00 2001 From: "neiljp (Neil Pilgrim)" Date: Wed, 6 Nov 2019 06:31:30 -0800 Subject: [PATCH] mypy: Clarify type hints in zulip/integrations/. --- zulip/integrations/codebase/zulip_codebase_mirror | 2 +- zulip/integrations/jabber/jabber_mirror_backend.py | 4 ++-- zulip/integrations/zephyr/zephyr_mirror_backend.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/zulip/integrations/codebase/zulip_codebase_mirror b/zulip/integrations/codebase/zulip_codebase_mirror index 66f8e23..5e8d46d 100755 --- a/zulip/integrations/codebase/zulip_codebase_mirror +++ b/zulip/integrations/codebase/zulip_codebase_mirror @@ -63,7 +63,7 @@ def make_api_call(path): "Content-Type": "application/json", "Accept": "application/json"}) if response.status_code == 200: - return json.loads(response.text) + return json.loads(response.text) # type: ignore # dynamic import if response.status_code >= 500: logging.error(str(response.status_code)) diff --git a/zulip/integrations/jabber/jabber_mirror_backend.py b/zulip/integrations/jabber/jabber_mirror_backend.py index 8442092..3b0b153 100755 --- a/zulip/integrations/jabber/jabber_mirror_backend.py +++ b/zulip/integrations/jabber/jabber_mirror_backend.py @@ -37,7 +37,7 @@ # | other sender| x | | | # public mode +-------------+-----+----+--------+---- # | self sender | | | | -from typing import Dict, List, Set +from typing import Dict, List, Set, Optional import logging import threading @@ -216,7 +216,7 @@ class ZulipToJabberBot(object): def __init__(self, zulip_client): # type: (Client) -> None self.client = zulip_client - self.jabber = None + self.jabber = None # type: Optional[JabberToZulipBot] def set_jabber_client(self, client): # type: (JabberToZulipBot) -> None diff --git a/zulip/integrations/zephyr/zephyr_mirror_backend.py b/zulip/integrations/zephyr/zephyr_mirror_backend.py index bb2e382..ded3422 100755 --- a/zulip/integrations/zephyr/zephyr_mirror_backend.py +++ b/zulip/integrations/zephyr/zephyr_mirror_backend.py @@ -341,7 +341,7 @@ def decrypt_zephyr(zephyr_class, instance, body): return decrypted def process_notice(notice, log): - # type: (zulip, Optional[IO[Any]]) -> None + # type: (Any, Optional[IO[Any]]) -> None (zsig, body) = parse_zephyr_body(notice.message, notice.format) is_personal = False is_huddle = False