From fe6deb2e03fec9002ad47c73ecfdbed0812d6e1d Mon Sep 17 00:00:00 2001 From: Alena Volkova Date: Wed, 11 Oct 2017 20:54:09 -0400 Subject: [PATCH] mypy: zulip: Fix errors in tests/test_default_arguments.py. --- tools/run-mypy | 1 - zulip/tests/test_default_arguments.py | 7 +++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/run-mypy b/tools/run-mypy index eb60563..4f217be 100755 --- a/tools/run-mypy +++ b/tools/run-mypy @@ -20,7 +20,6 @@ sys.path.append(os.path.dirname(TOOLS_DIR)) exclude = """ zulip/integrations/perforce/git_p4.py -zulip/tests/test_default_arguments.py zulip_bots/zulip_bots/bots zulip_bots/generate_manifest.py diff --git a/zulip/tests/test_default_arguments.py b/zulip/tests/test_default_arguments.py index 659b397..60a1d79 100755 --- a/zulip/tests/test_default_arguments.py +++ b/zulip/tests/test_default_arguments.py @@ -16,9 +16,11 @@ else: class TestDefaultArguments(TestCase): def test_invalid_arguments(self): + # type: () -> None parser = zulip.add_default_arguments(argparse.ArgumentParser(usage="lorem ipsum")) - with self.assertRaises(SystemExit) as cm, patch('sys.stderr', new=six.StringIO()) as mock_stderr: - parser.parse_args(['invalid argument']) + with self.assertRaises(SystemExit) as cm: # type: ignore # error: "assertRaises" doesn't match argument types + with patch('sys.stderr', new=six.StringIO()) as mock_stderr: + parser.parse_args(['invalid argument']) self.assertEqual(cm.exception.code, 2) # Assert that invalid arguments exit with printing the full usage (non-standard behavior) self.assertTrue(mock_stderr.getvalue().startswith("""usage: lorem ipsum @@ -32,6 +34,7 @@ Zulip API configuration: @patch('os.path.exists', return_value=False) def test_config_path_with_tilde(self, mock_os_path_exists): + # type: (bool) -> None parser = zulip.add_default_arguments(argparse.ArgumentParser(usage="lorem ipsum")) test_path = '~/zuliprc' args = parser.parse_args(['--config-file', test_path])