25bb86d2d0
The refactoring that we did a couple weeks ago to make the zephyr mirror script restart itself automatically (by splitting it into zephyr_mirror.py and zephyr_mirror_backend.py) had a poor interaction with our code for killing old zephyr_mirror processes (to prevent double-mirroring). If you manually ran two copies of the outer mirroring script (zephyr_mirror.py), then the second one would on startup kill the first one's zephyr_mirror_backend.py children (for being duplicate zephyr_mirror_backend.py processes that would result in double-mirroring). However, importantly, it did not kill the first mirroring script's zephyr_mirror.py parent process, so the first mirroring script would then proceed to startup up new children. The process then repeats, with the two scripts' roles reversed. This issue didn't affect the sharded mirroring case, where I had been doing the testing of the kill code with that refactoring, because we don't have a version of the outer zephyr_mirror.py loop for that situation (a consequence of it being hard to restart the threads properly with the run_parallel API that we're using to spawn all the children). (imported from commit d4886ac77312a6b0ebd0d612f6fb084970bf23a2) |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| check-mirroring | ||
| feedback-bot | ||
| gcal-bot | ||
| humbug_trac.py | ||
| mit_subs_list.py | ||
| send-nagios-notification | ||
| tddium-notify-humbug | ||
| zephyr-mirror-crontab | ||
| zephyr_mirror.py | ||
| zephyr_mirror_backend.py | ||